Pass compressHTML settings to manifest#7488
Merged
natemoo-re merged 3 commits intomainfrom Jun 28, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 053324c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Jun 27, 2023
ematipico
requested changes
Jun 27, 2023
Member
|
I think I can see if more as a bug fix as we expect HTML compression to work everywhere, but it didn't handle the manifest part. The new property is an implementation detail of the bug fix. It would be nice to have a test though. |
ematipico
approved these changes
Jun 28, 2023
Merged
matthewp
pushed a commit
that referenced
this pull request
Jul 11, 2023
* fix(#7333): pass compressHTML to manifest * chore: add compressHTML to astro:ssr-manifest test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
compressHTMLsetting was not passed through to adapters because we weren't saving it in the manifestcompressHTMLand the baseAppwill pass this setting through torenderPageTesting
Tested manually, but will add a test
Docs
N/A, bug fix only